diff --git a/snippets/deepClone.md b/snippets/deepClone.md index 8f87cd688..961c12157 100644 --- a/snippets/deepClone.md +++ b/snippets/deepClone.md @@ -12,7 +12,7 @@ const deepClone = obj => { Object.keys(clone).forEach( key => (clone[key] = typeof obj[key] === 'object' ? deepClone(obj[key]) : obj[key]) ); - return Array.isArray(obj) ? (clone.length = obj.length) && Array.from(clone) : clone; + return Array.isArray(obj) ? Array.from({ length: obj.length }) : clone; }; ``` diff --git a/test/deepClone.test.js b/test/deepClone.test.js index 9e73c19d1..688ac9dd9 100644 --- a/test/deepClone.test.js +++ b/test/deepClone.test.js @@ -8,6 +8,8 @@ const a = { foo: 'bar', obj: { a: 1, b: 2 } }; const b = deepClone(a); const c = [{ foo: 'bar' }]; const d = deepClone(c); +const e = { edge: [] }; +const f = deepClone(e); test('Shallow cloning works', () => { expect(a).not.toBe(b); }); @@ -20,3 +22,6 @@ test('Array shallow cloning works', () => { test('Array deep cloning works', () => { expect(c[0]).not.toBe(d[0]); }); +test('Array shallow cloning edge case works', () => { + expect(f.edge).toEqual([]); +});