From 96d61565ea4e2ce570d408619a9e4ad8c5f83b97 Mon Sep 17 00:00:00 2001 From: Robert Mennell Date: Sat, 13 Apr 2019 00:24:37 -0700 Subject: [PATCH 1/2] Maps and Sets are not collections, but Stores They use size instead of length --- snippets/isEmpty.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/snippets/isEmpty.md b/snippets/isEmpty.md index f620f3727..00f62420d 100644 --- a/snippets/isEmpty.md +++ b/snippets/isEmpty.md @@ -1,6 +1,6 @@ ### isEmpty -Returns true if the a value is an empty object, collection, map or set, has no enumerable properties or is any type that is not considered a collection. +Returns true if the a value is an empty object, collection, has no enumerable properties or is any type that is not considered a collection. Check if the provided value is `null` or if its `length` is equal to `0`. From 8629d97eb509ba5fa80e118b43722b6c9cfec9f4 Mon Sep 17 00:00:00 2001 From: Robert Mennell Date: Sat, 13 Apr 2019 00:27:28 -0700 Subject: [PATCH 2/2] remove Map and Set as the tests are wrong --- snippets/isEmpty.md | 2 -- 1 file changed, 2 deletions(-) diff --git a/snippets/isEmpty.md b/snippets/isEmpty.md index 00f62420d..5dcd23708 100644 --- a/snippets/isEmpty.md +++ b/snippets/isEmpty.md @@ -9,8 +9,6 @@ const isEmpty = val => val == null || !(Object.keys(val) || val).length; ``` ```js -isEmpty(new Map()); // true -isEmpty(new Set()); // true isEmpty([]); // true isEmpty({}); // true isEmpty(''); // true