From 23835dbdb984f28eedf51eb1d75867e581a856e9 Mon Sep 17 00:00:00 2001 From: Rohit Tanwar <31792358+kriadmin@users.noreply.github.com> Date: Mon, 1 Jan 2018 16:14:48 +0530 Subject: [PATCH] Remove changes suggested by @atomiks --- snippets/join.md | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/snippets/join.md b/snippets/join.md index 93f1d0e02..f951070e5 100644 --- a/snippets/join.md +++ b/snippets/join.md @@ -3,8 +3,11 @@ Is like `Array.join()` but with an additional argument of `end`(is equal to `separator` by default) which is used to separate the second to last and last items in the array. Returns `""` when the array is empty and the first item when the length of array is 1. ```js -const join = (arr, separator = ',', end = separator) => - arr.slice(0, arr.length - 1).join(separator) + end + arr[arr.length - 1] +const join = (arr,separator = ',',end = separator ) => { + return arr.reduce((acc,val,i) => { + return i == arr.length - 2 ? acc + val + end : i == arr.length - 1 ? acc + val : acc + val + separator + },'') + } ``` ```js