From 2629765340d5d1cb3c9a76e79eef9f8863660ee6 Mon Sep 17 00:00:00 2001 From: Robert Mennell Date: Mon, 8 Jan 2018 13:24:21 -0800 Subject: [PATCH] Update indexOfAll snippet return type Now we're just going to return an empty array. This keeps a consistent return type, does not need checking, and won't break api chaining. Decision was made because otherwise you'd have to add a filter step or check if the return is not an array. Instead we just want an empty array so it has a consistent API, and no indeces is a valid amount --- snippets/indexOfAll.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/snippets/indexOfAll.md b/snippets/indexOfAll.md index e06f58946..b3485f3c4 100644 --- a/snippets/indexOfAll.md +++ b/snippets/indexOfAll.md @@ -9,11 +9,11 @@ Return `[-1]` if `length` of the array of indices is `0`, otherwise return the a const indexOfAll = (arr, val) => { const indices = []; arr.forEach((el, i) => el === val && indices.push(i)); - return indices.length ? indices : [-1]; + return indices; }; ``` ```js indexOfAll([1, 2, 3, 1, 2, 3], 1); // [0,3] -indexOfAll([1, 2, 3], 4); // [-1] +indexOfAll([1, 2, 3], 4); // [] ```