Revision after review 1

This commit is contained in:
Theodorus Yoga
2019-09-19 19:15:56 +07:00
parent 15ef366c07
commit 284c5b936e

View File

@ -10,7 +10,7 @@ Creates an alert component with `type` prop.
- Define `timeoutId` to keep the timer instance for clearing on component unmount. - Define `timeoutId` to keep the timer instance for clearing on component unmount.
- Use the `React.setEffect()` hook to update the value of `isShown` to `true` and clear interval by using `timeoutId` when component is unmounted. - Use the `React.setEffect()` hook to update the value of `isShown` to `true` and clear interval by using `timeoutId` when component is unmounted.
- Define `closeNotification` function to set the component is removed from DOM by displaying fading out animation and set `isShown` to `false` via `setTimeout()`. - Define `closeNotification` function to set the component is removed from DOM by displaying fading out animation and set `isShown` to `false` via `setTimeout()`.
- Define the component, which renders alert component with user defined `message` and a close button to remove the component from DOM. - Define the component, which renders the alert component with user defined `message` and a close button to remove the component from DOM.
```css ```css
@keyframes leave { @keyframes leave {
@ -28,25 +28,13 @@ Creates an alert component with `type` prop.
position: relative; position: relative;
} }
.alert.success {
color: #155724;
background-color: #d4edda;
border-color: #c3e6cb;
}
.alert.info{
color: #004085;
background-color: #cce5ff;
border-color: #b8daff;
}
.alert.warning{ .alert.warning{
color: #856404; color: #856404;
background-color: #fff3cd; background-color: #fff3cd;
border-color: #ffeeba; border-color: #ffeeba;
} }
.alert.danger{ .alert.error{
color: #721c24; color: #721c24;
background-color: #f8d7da; background-color: #f8d7da;
border-color: #f5c6cb; border-color: #f5c6cb;
@ -69,6 +57,10 @@ Creates an alert component with `type` prop.
font-weight: 600; font-weight: 600;
font-size: 16px; font-size: 16px;
} }
.alert .close:after{
content: 'x';
}
``` ```
```jsx ```jsx
@ -95,7 +87,7 @@ function Notification(props) {
return isShown && ( return isShown && (
<div className={`alert ${props.type}${isLeaving ? ' leaving' : ''}`}> <div className={`alert ${props.type}${isLeaving ? ' leaving' : ''}`}>
<button className="close" onClick={closeNotification}>x</button> <button className="close" onClick={closeNotification} />
{props.message} {props.message}
</div> </div>
) )