From 01c43e6cac2f364cc77e1696239da391a51745f7 Mon Sep 17 00:00:00 2001 From: Rohit Tanwar <31792358+kriadmin@users.noreply.github.com> Date: Sun, 21 Jan 2018 12:36:02 +0530 Subject: [PATCH 1/4] Change to snake_case --- snippet_template.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/snippet_template.md b/snippet_template.md index 2cc4e2a68..f1cf31008 100644 --- a/snippet_template.md +++ b/snippet_template.md @@ -1,15 +1,15 @@ -### functionName +### function_name Describe briefly what the function does Explain your method and the functions used. ``` python -def functionName(args): +def function_name(args): # code return 0 ``` ``` python -functionName(val) # result -``` \ No newline at end of file +function_name(val) # result +``` From 13bd7d27b1ef7871ecf92677d2bbe88a142637dc Mon Sep 17 00:00:00 2001 From: Rohit Tanwar <31792358+kriadmin@users.noreply.github.com> Date: Sun, 21 Jan 2018 12:38:41 +0530 Subject: [PATCH 2/4] Update Contributing.md --- CONTRIBUTING.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 5e84a14e0..c3c3656cb 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -38,6 +38,8 @@ Here's what you can do to help: - It is not mandatory but highly appreciated if you provide **test cases** and/or performance tests. - You can start creating a new snippet, by using the [snippet template](snippet_template.md) to format your snippets. - Updating the README.md file should only be done by altering the scripts in the **scripts** folder or altering their relative static parts in the **static-parts** folder. +- You may tag your snippet in tag_databse although it is _not_ necessary. +- You may also run `scripts\lint.py` & `scripts\readme.py`. - [ ] My code follows the code style of this project. - [ ] My change requires a change to the documentation. -- [ ] I have updated the documentation accordingly. +- [ ] I have updated the documentation accordingly. - [ ] I have checked that the changes are working properly - [ ] I have checked that there isn't any PR doing the same - [ ] I have read the **CONTRIBUTING** document. From 4f241242f145e60a65dfd0c330a5bff272fa2b21 Mon Sep 17 00:00:00 2001 From: Rohit Tanwar <31792358+kriadmin@users.noreply.github.com> Date: Sun, 21 Jan 2018 12:40:45 +0530 Subject: [PATCH 4/4] Update PULL_REQUEST_TEMPLATE.md --- .github/PULL_REQUEST_TEMPLATE.md | 6 ------ 1 file changed, 6 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 12734a844..d768fd4d5 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -17,12 +17,6 @@ - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) -## [30 seconds of code backlog](https://github.com/Chalarangelo/30-seconds-of-code/) - - -- [ ] I added the prefix [UPDATE: `method.md`] or [ADD: `method.md`] -- [ ] I have referenced the `method` to the lodash backlog. - ## Checklist: - [ ] My code follows the code style of this project.