From 138b7cf7ebeca1e9f67225e2e3190a829b086130 Mon Sep 17 00:00:00 2001 From: Robert Mennell Date: Thu, 29 Nov 2018 00:32:16 -0800 Subject: [PATCH 1/2] Update Modal Dialogue notes about styling Since this uses a 'portal' that is agnostic of implementation, the note should be updated to reflect this could just go right next to the body tag. This should be easy enough to do with another react-dom, but if people can't figure that out on their own... --- snippets/ModalDialog.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/snippets/ModalDialog.md b/snippets/ModalDialog.md index 1dc392699..b255f2306 100644 --- a/snippets/ModalDialog.md +++ b/snippets/ModalDialog.md @@ -133,7 +133,7 @@ ModalDialog.show({ ``` #### Notes: -* This component includes a lot of CSS, which might conflict with other CSS in your project. +* This component includes a lot of CSS, which might conflict with other CSS in your project. It is recomended that the modal a direct child of the body tag. * A more up-to-date method with lower compatibility is to use [Portals](https://reactjs.org/docs/portals.html) in React 16+. From c77b6bf53ac459c8496a5b89a5c1157a6c68551e Mon Sep 17 00:00:00 2001 From: Angelos Chalaris Date: Thu, 29 Nov 2018 10:33:26 +0200 Subject: [PATCH 2/2] Update ModalDialog.md --- snippets/ModalDialog.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/snippets/ModalDialog.md b/snippets/ModalDialog.md index b255f2306..c069c924f 100644 --- a/snippets/ModalDialog.md +++ b/snippets/ModalDialog.md @@ -133,7 +133,7 @@ ModalDialog.show({ ``` #### Notes: -* This component includes a lot of CSS, which might conflict with other CSS in your project. It is recomended that the modal a direct child of the body tag. +* This component includes a lot of CSS, which might conflict with other CSS in your project. It is recomended for the modal to be a direct child of the body tag. * A more up-to-date method with lower compatibility is to use [Portals](https://reactjs.org/docs/portals.html) in React 16+.