From d756f47860ac64b1fbcb47514965396d5a49c251 Mon Sep 17 00:00:00 2001 From: iamsoorena Date: Fri, 22 Dec 2017 18:51:50 +0330 Subject: [PATCH 1/3] I found a way more ES6ish way to do this --- snippets/toDecimalMark.md | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/snippets/toDecimalMark.md b/snippets/toDecimalMark.md index 802578ec5..4ad259f35 100644 --- a/snippets/toDecimalMark.md +++ b/snippets/toDecimalMark.md @@ -1,14 +1,8 @@ ### toDecimalMark -Convert a float-point arithmetic to the [Decimal mark](https://en.wikipedia.org/wiki/Decimal_mark) form. - -Use `toString()` to convert the float `num` to a string, then use regex to separate every three characters of the integer part with a comma. -Use [Ttemplate Literals](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals) to return joined parts. +Use `toLocaleString()` to convert a float-point arithmetic to the [Decimal mark](https://en.wikipedia.org/wiki/Decimal_mark) form. It makes a comma separated string from a number. ```js -const toDecimalMark = (num) => { - let numberParts = num.toString().split('.') - return `${numberParts[0].replace(/\B(?=(\d{3})+(?!\d))/g, ',')}.${numberParts[1]}` -} -// toDecimalMark(12305030388.9087) //-> '12,305,030,388.9087' +const toDecimalMark = (num) => num.toLocaleString() +// toDecimalMark(12305030388.9087) -> "12,305,030,388.9087" ``` From 388c56ce2fc16b39751cf19e3969f55d280daf9c Mon Sep 17 00:00:00 2001 From: Soorena Date: Fri, 22 Dec 2017 19:01:24 +0330 Subject: [PATCH 2/3] Update toDecimalMark.md --- snippets/toDecimalMark.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/snippets/toDecimalMark.md b/snippets/toDecimalMark.md index 4ad259f35..bb7cadf52 100644 --- a/snippets/toDecimalMark.md +++ b/snippets/toDecimalMark.md @@ -3,6 +3,6 @@ Use `toLocaleString()` to convert a float-point arithmetic to the [Decimal mark](https://en.wikipedia.org/wiki/Decimal_mark) form. It makes a comma separated string from a number. ```js -const toDecimalMark = (num) => num.toLocaleString() +const toDecimalMark = num => num.toLocaleString() // toDecimalMark(12305030388.9087) -> "12,305,030,388.9087" ``` From e11c32070615bf2367a041e74c274e5636c80d9f Mon Sep 17 00:00:00 2001 From: Soorena Date: Fri, 22 Dec 2017 20:56:08 +0330 Subject: [PATCH 3/3] Update toDecimalMark.md --- snippets/toDecimalMark.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/snippets/toDecimalMark.md b/snippets/toDecimalMark.md index bb7cadf52..94e821376 100644 --- a/snippets/toDecimalMark.md +++ b/snippets/toDecimalMark.md @@ -3,6 +3,6 @@ Use `toLocaleString()` to convert a float-point arithmetic to the [Decimal mark](https://en.wikipedia.org/wiki/Decimal_mark) form. It makes a comma separated string from a number. ```js -const toDecimalMark = num => num.toLocaleString() +const toDecimalMark = num => num.toLocaleString("en-US"); // toDecimalMark(12305030388.9087) -> "12,305,030,388.9087" ```