From 7d47cf05dbed6fbc292cc280380bf358c6f85e07 Mon Sep 17 00:00:00 2001 From: iamsoorena Date: Fri, 22 Dec 2017 15:00:46 +0330 Subject: [PATCH] Remove redundant number characters check Remove unnecessary multiple array making with `.split()` Reducing lines and making it more terse and readable --- snippets/toDecimalMark.md | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/snippets/toDecimalMark.md b/snippets/toDecimalMark.md index 79cea1840..deb196bed 100644 --- a/snippets/toDecimalMark.md +++ b/snippets/toDecimalMark.md @@ -6,12 +6,8 @@ Use `toString()` to convert the float `num` to a string, then use regex to separ ```js const toDecimalMark = (num) => { - let cleanNum = num.toString().split('').filter(n => '0123456789.'.includes(n)).join('') - let wholeNum = cleanNum.split('.')[0].replace(/\B(?=(\d{3})+(?!\d))/g, ",") - let decNum = `.${cleanNum.split('.')[1]}` - return wholeNum + decNum; + let numberParts = num.toString().split('.') + return `${numberParts[0].replace(/\B(?=(\d{3})+(?!\d))/g, ',')}.${numberParts[1]}` } // toDecimalMark(12305030388.9087) //-> '12,305,030,388.9087' -// toDecimalMark(123.889087e2) //-> '12,388.9087' -// toDecimalMark('12305abc030388.9087') // -> '12,305,030,388.9087' ```