From abfd68b38b98c68955f6e33d762511be0b772866 Mon Sep 17 00:00:00 2001 From: iamsoorena Date: Sun, 17 Dec 2017 00:55:22 +0330 Subject: [PATCH 1/3] adding intellij related files to gitignore --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 9fe5cb489..22010c5cb 100644 --- a/.gitignore +++ b/.gitignore @@ -1,3 +1,4 @@ node_modules/ currentSnippet\.js *.md.temp.js +.idea From b70b5b0d9589b2185afda704c9f561f4778101b4 Mon Sep 17 00:00:00 2001 From: iamsoorena Date: Sun, 17 Dec 2017 01:05:53 +0330 Subject: [PATCH 2/3] removing duplicate code and converting it to one line using `shortHex.startsWith('#') ? 1 : 0` making function more terse removing unnecessary empty strings. --- snippets/3-digit-hexcode-to-6-digit-hexcode.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/snippets/3-digit-hexcode-to-6-digit-hexcode.md b/snippets/3-digit-hexcode-to-6-digit-hexcode.md index a138b34bb..17a4561db 100644 --- a/snippets/3-digit-hexcode-to-6-digit-hexcode.md +++ b/snippets/3-digit-hexcode-to-6-digit-hexcode.md @@ -4,8 +4,7 @@ Use `Array.map()`, `split()` and `Array.join()` to join the mapped array for con ```js const convertHex = shortHex => - shortHex[0] == '#' ? ('#' + shortHex.slice(1).split('').map(x => x+x).join('')) : - ('#' + shortHex.split('').map(x => x+x).join('')); + '#' + shortHex.slice(shortHex.startsWith('#') ? 1 : 0).split().map(x => x+x).join() // convertHex('#03f') -> '#0033ff' // convertHex('05a') -> '#0055aa' ``` From 625e49f5899e24b756dfa7d7f83c9219cc514ca0 Mon Sep 17 00:00:00 2001 From: iamsoorena Date: Sun, 17 Dec 2017 01:08:34 +0330 Subject: [PATCH 3/3] updating description to address slice() part functionality --- snippets/3-digit-hexcode-to-6-digit-hexcode.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/snippets/3-digit-hexcode-to-6-digit-hexcode.md b/snippets/3-digit-hexcode-to-6-digit-hexcode.md index 17a4561db..3c1c87261 100644 --- a/snippets/3-digit-hexcode-to-6-digit-hexcode.md +++ b/snippets/3-digit-hexcode-to-6-digit-hexcode.md @@ -1,7 +1,7 @@ ### 3-digit hexcode to 6-digit hexcode -Use `Array.map()`, `split()` and `Array.join()` to join the mapped array for converting a three-digit RGB notated hexadecimal colorcode to the six-digit form. - +Use `Array.map()`, `split()` and `Array.join()` to join the mapped array for converting a three-digit RGB notated hexadecimal color-code to the six-digit form. +`Array.slice()` is used to remove `#` from string start since it's added once. ```js const convertHex = shortHex => '#' + shortHex.slice(shortHex.startsWith('#') ? 1 : 0).split().map(x => x+x).join()