andre/30-seconds-of-code
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix incorrect test for sortedLastIndex snippet

Browse Source
This commit is contained in:
tcmal
2018-03-12 19:36:47 +00:00
parent 3966e6d9b1
commit 9b572cc7b6
3 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
snippets/sortedLastIndex.md
View File

@ -9,7 +9,7 @@ Use `Array.reverse()` and `Array.findIndex()` to find the appropriate last index
const sortedLastIndex = (arr, n) => { const sortedLastIndex = (arr, n) => {
const isDescending = arr[0] > arr[arr.length - 1]; const isDescending = arr[0] > arr[arr.length - 1];
const index = arr.reverse().findIndex(el => (isDescending ? n <= el : n >= el)); const index = arr.reverse().findIndex(el => (isDescending ? n <= el : n >= el));
return index === -1 ? 0 : arr.length - index - 1; return index === -1 ? 0 : arr.length - index;
}; };
``` ```

2
test/sortedLastIndex/sortedLastIndex.js
View File

@ -1,6 +1,6 @@
const sortedLastIndex = (arr, n) => { const sortedLastIndex = (arr, n) => {
const isDescending = arr[0] > arr[arr.length - 1]; const isDescending = arr[0] > arr[arr.length - 1];
const index = arr.reverse().findIndex(el => (isDescending ? n <= el : n >= el)); const index = arr.reverse().findIndex(el => (isDescending ? n <= el : n >= el));
return index === -1 ? 0 : arr.length - index - 1; return index === -1 ? 0 : arr.length - index;
}; };
module.exports = sortedLastIndex; module.exports = sortedLastIndex;

4
test/sortedLastIndex/sortedLastIndex.test.js
View File

@ -5,8 +5,8 @@ test('Testing sortedLastIndex', (t) => {
//For more information on all the methods supported by tape //For more information on all the methods supported by tape
//Please go to https://github.com/substack/tape //Please go to https://github.com/substack/tape
t.true(typeof sortedLastIndex === 'function', 'sortedLastIndex is a Function'); t.true(typeof sortedLastIndex === 'function', 'sortedLastIndex is a Function');
t.equal(sortedLastIndex([10, 20, 30, 30, 40], 30), 3, 'Returns the highest index to insert the element without messing up the list order'); t.equal(sortedLastIndex([10, 20, 30, 30, 40], 30), 4, 'Returns the highest index to insert the element without messing up the list order');
//t.deepEqual(sortedLastIndex(args..), 'Expected'); //t.deepEqual(sortedLastIndex(args..), 'Expected');
//t.equal(sortedLastIndex(args..), 'Expected'); //t.equal(sortedLastIndex(args..), 'Expected');
//t.false(sortedLastIndex(args..), 'Expected'); //t.false(sortedLastIndex(args..), 'Expected');
//t.throws(sortedLastIndex(args..), 'Expected'); //t.throws(sortedLastIndex(args..), 'Expected');