From aab7a8da221a5cfd930395275eedb20551f0aa67 Mon Sep 17 00:00:00 2001 From: Elder Henrique Souza Date: Tue, 12 Dec 2017 14:45:24 -0200 Subject: [PATCH] Update fibonacci-array-generator.md The fibonacci sequence being zero indexed as well as the arrays, I think we could just initialize an array with the passed length, fill it with zeroes and use the indexes for the first positions. --- snippets/fibonacci-array-generator.md | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/snippets/fibonacci-array-generator.md b/snippets/fibonacci-array-generator.md index ef6a2a975..38cfbc943 100644 --- a/snippets/fibonacci-array-generator.md +++ b/snippets/fibonacci-array-generator.md @@ -4,11 +4,13 @@ Create an empty array of the specific length, initializing the first two values Use `reduce()` to add values into the array, using the sum of the last two values, except for the first two. ```js -const fibonacci = n => - Array.apply(null, [0,1].concat(Array(n-2))).reduce( - (acc, val, i) => { - acc.push( i>1 ? acc[i-1]+acc[i-2] : val); +const fibonacci = n => { + return Array(n) + .fill(0) + .reduce((acc, val, i) => { + acc.push(i > 1 ? acc[i - 1] + acc[i - 2] : i); return acc; },[]); +} // fibonacci(5) -> [0,1,1,2,3] ```