diff --git a/snippets/objectToQueryString.md b/snippets/objectToQueryString.md index e54879001..bb5da7fc5 100644 --- a/snippets/objectToQueryString.md +++ b/snippets/objectToQueryString.md @@ -6,14 +6,14 @@ tags: utility,object,function,intermediate Returns a query string generated from the key-value pairs of the given object. Use `Array.prototype.reduce()` on `Object.entries(queryParameters)` to create the query string. -Determine the `symbol` to be either `?` or `&` based on the `index` and concatenate `val` to `queryString` only if it's a string. +Determine the `symbol` to be either `?` or `&` based on the `length` of `queryString` and concatenate `val` to `queryString` only if it's a string. Return the `queryString` or an empty string when the `queryParameters` are falsy. ```js const objectToQueryString = queryParameters => { return queryParameters ? Object.entries(queryParameters).reduce((queryString, [key, val], index) => { - const symbol = index === 0 ? '?' : '&'; + const symbol = queryString.length === 0 ? '?' : '&'; queryString += typeof val === 'string' ? `${symbol}${key}=${val}` : ''; return queryString; }, '')