From f6882990990fd0545a31dc9ad062a202fb1f8871 Mon Sep 17 00:00:00 2001 From: Rohit Tanwar <31792358+kriadmin@users.noreply.github.com> Date: Wed, 7 Mar 2018 21:12:40 +0530 Subject: [PATCH] Update Tag.js Make it shorter --- src/js/components/Tag.js | 35 ++++++++++------------------------- 1 file changed, 10 insertions(+), 25 deletions(-) diff --git a/src/js/components/Tag.js b/src/js/components/Tag.js index 9393bf9b4..d18127680 100644 --- a/src/js/components/Tag.js +++ b/src/js/components/Tag.js @@ -3,35 +3,20 @@ import { select, selectAll, on } from '../deps/utils' const tagButtons = selectAll('button.tags__tag') let isShiftSelected = false; const onClick = function() { - let currentElements = [...document.querySelector('button.tags__tag.is-active')] if(isShiftSelected && this.dataset.type === 'all'){ - tagButtons.forEach(button => button.classList.remove('is-active')) - } - else if(isShiftSelected){ - document.querySelector('button[type=all]').classList.remove('is-active') - } - else { - tagButtons.forEach(button => button.classList.remove('is-active')) - } - if(this.classList.contains('is-active') && this.dataset.type === 'all'){ - this.classList.add('is-active') - currentElements = [this] - } - else if(this.classList.contains('is-active')){ - this.classList.remove('is-active') - currentElements.splice(currentElements.indexOf(this),1) - } - else { + tagButtons.forEach(button => button.classList.remove('is-active')); + this.classList.add('is-active'); + } + else if(isShiftSelected) { + this.classList.add('is-active'); + select('button[data-type=all]').classList.reomove('is-active'); + } + else { + tagButtons.forEach(button => button.classList.remove('is-active')); this.classList.add('is-active'); - if(isShiftSelected){ - currentElements.push(this) - } - else{ - currentElements = [this] - } } EventHub.emit('Tag.click', { - type: currentElements.map(el => el.dataset.type) + type: [...selectAll('button.tags__tag.is-avtive')] }) } onkeydown = e => (