From dedc12f269f0df4eed880df39c7dd0083253702d Mon Sep 17 00:00:00 2001 From: Sparkadelic177 Date: Fri, 7 Aug 2020 10:11:48 -0400 Subject: [PATCH 1/3] Resolves #1176 --- snippets/flattenObject.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/snippets/flattenObject.md b/snippets/flattenObject.md index ce47de292..1f80548bb 100644 --- a/snippets/flattenObject.md +++ b/snippets/flattenObject.md @@ -12,12 +12,12 @@ Otherwise, it adds the appropriate prefixed key-value pair to the accumulator ob You should always omit the second argument, `prefix`, unless you want every key to have a prefix. ```js -const flattenObject = (obj, prefix = '') => +const flattenObject = (obj, prefix = '') => Object.keys(obj).reduce((acc, k) => { - const pre = prefix.length ? prefix + '.' : ''; - if (typeof obj[k] === 'object') Object.assign(acc, flattenObject(obj[k], pre + k)); - else acc[pre + k] = obj[k]; - return acc; + const pre = prefix.length ? prefix + '.' : ''; + if (typeof obj[k] === 'object' && obj[k] !== null && Object.keys(obj[k]).length > 0) Object.assign(acc, flattenObject(obj[k], pre + k)); + else acc[pre + k] = obj[k]; + return acc; }, {}); ``` From 089779edf2efc808c6e504cfa5f98bbc694c7147 Mon Sep 17 00:00:00 2001 From: Sparkadelic177 Date: Fri, 7 Aug 2020 10:16:26 -0400 Subject: [PATCH 2/3] Resolves #1176 --- snippets/flattenObject.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/snippets/flattenObject.md b/snippets/flattenObject.md index 1f80548bb..51f9ff281 100644 --- a/snippets/flattenObject.md +++ b/snippets/flattenObject.md @@ -12,12 +12,12 @@ Otherwise, it adds the appropriate prefixed key-value pair to the accumulator ob You should always omit the second argument, `prefix`, unless you want every key to have a prefix. ```js -const flattenObject = (obj, prefix = '') => +const flattenObject = (obj, prefix = '') => Object.keys(obj).reduce((acc, k) => { - const pre = prefix.length ? prefix + '.' : ''; - if (typeof obj[k] === 'object' && obj[k] !== null && Object.keys(obj[k]).length > 0) Object.assign(acc, flattenObject(obj[k], pre + k)); - else acc[pre + k] = obj[k]; - return acc; + const pre = prefix.length ? prefix + '.' : ''; + if (typeof obj[k] === 'object' && obj[k] !== null && Object.keys(obj[k]).length > 0) Object.assign(acc, flattenObject(obj[k], pre + k)); + else acc[pre + k] = obj[k]; + return acc; }, {}); ``` From 6c3b563ae62d4c840f596b5011c14474997540a4 Mon Sep 17 00:00:00 2001 From: Angelos Chalaris Date: Mon, 10 Aug 2020 09:03:49 +0300 Subject: [PATCH 3/3] Update flattenObject.md --- snippets/flattenObject.md | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/snippets/flattenObject.md b/snippets/flattenObject.md index 51f9ff281..05624115e 100644 --- a/snippets/flattenObject.md +++ b/snippets/flattenObject.md @@ -14,8 +14,13 @@ You should always omit the second argument, `prefix`, unless you want every key ```js const flattenObject = (obj, prefix = '') => Object.keys(obj).reduce((acc, k) => { - const pre = prefix.length ? prefix + '.' : ''; - if (typeof obj[k] === 'object' && obj[k] !== null && Object.keys(obj[k]).length > 0) Object.assign(acc, flattenObject(obj[k], pre + k)); + const pre = prefix.length ? `${prefix}.` : ''; + if ( + typeof obj[k] === 'object' && + obj[k] !== null && + Object.keys(obj[k]).length > 0 + ) + Object.assign(acc, flattenObject(obj[k], pre + k)); else acc[pre + k] = obj[k]; return acc; }, {}); @@ -23,4 +28,4 @@ const flattenObject = (obj, prefix = '') => ```js flattenObject({ a: { b: { c: 1 } }, d: 1 }); // { 'a.b.c': 1, d: 1 } -``` \ No newline at end of file +```