Updating guidelines and a tag
This commit is contained in:
@ -17,8 +17,8 @@ As a member of the team that manages **30 seconds of code**, you have the follow
|
||||
- **For a pull request to be considered ready to merge, there should be at least 2 (preferrably 3) reviews approving it for merge.** There are, however, certain exceptions:
|
||||
- **If a pull request only fixes typos**, there is no need to wait for a second reviewer (unless you are not absolutely certain these were not typos in the first place).
|
||||
- **If a pull request only clarifies a snippet's description or enforces the styleguide for an existng snippet**, you might be able to merge it without getting a second reviewer to review it, but only if you are absolutely certain about it.
|
||||
- **Make sure pull requests pass the Travis CI build**, otherwise try and find out what's wrong and inform the author of the pull request.
|
||||
- **Changes to build scripts, guidelines and things that might break the processes we have in place need to be reviewed by [@Chalarangelo](https://github.com/Chalarangelo)** (this is temporary, but we need a baseline to make sure we break as few things as possible in the beginning).
|
||||
- **After merging a pull request, make sure to check for untagged snippets and tag them appropriately.** Try to keep all snippets tagged, so that the list and website are up to date.
|
||||
- (*Irrelevant once we set up CI*) **You should rebuild the README and website after merging pull requests and push to the repository, so that both files are up to date.**
|
||||
- **If you make changes or additions to existing snippets or if you want to add you own snippets, you will go through the pull request process that everyone else goes.** Exceptions apply similarly to the ones mentioned above about merging pull requests (i.e. typos, description clarification and the way script and build process changes are handled). Pull requests suggested by collaborators should be reviewed by at least two other collaborators to be considered ready to merge.
|
||||
- **Pull requests that are inactive for over a week should be closed or put on hold.**
|
||||
|
||||
@ -49,6 +49,7 @@ groupBy:array
|
||||
hammingDistance:math
|
||||
head:array
|
||||
hexToRGB:utility
|
||||
httpsRedirect:browser
|
||||
initial:array
|
||||
initialize2DArray:array
|
||||
initializeArrayWithRange:array
|
||||
|
||||
Reference in New Issue
Block a user